Just Java » Generics http://blog.cedarsoft.com Johannes Schneider (cedarsoft GmbH) about Java and related stuff Wed, 25 Aug 2010 09:46:33 +0000 http://wordpress.org/?v=2.8.4 en hourly 1 Generics and Wildcards: Part 1 http://blog.cedarsoft.com/2010/01/wildcards-and-collections-part-1/ http://blog.cedarsoft.com/2010/01/wildcards-and-collections-part-1/#comments Sat, 02 Jan 2010 13:34:33 +0000 johannes http://blog.cedarsoft.com/?p=75 Wildcards have been introduced to Java some years ago (in JDK 1.5). And they are easy to understand – as long as no collections are involved. Then everything becomes a little bit more complex…

This (and the following) blog posts will try to show in simple steps how to handle wildcards in collections correctly.

Collections + Generics = non intuitional

Every Java developer knows that an Integer is also a Number since Integer extends Number. So every time someone expects a Number (e.g. as method or constructor parameter), I may call the method with a parameter of type Integer (or Double, or…).

Every time I say Number, I literally mean:
An object of type Number or of any other class extending Number.

And every Java developer is used to understand it this way (ok, there might be some that don’t, but hey, those won’t read that blog post…).

When it comes to collections, most of the Java developers unconsciously transfer that understanding. At first glance it seems to be the same thing…
Set extends Collection: So when a method parameter is declared as Collection, it might be called using a Set (or List, or…).

Collections and their content

But collections don’t just have a type. They also contain objects. And those objects also have a type. And that is the point where the trouble begin. The first step seems to be very obvious.

List<Integer> is just a List containing Integers. List#add accepts an Integer, List#get returns an Integer…

And of course the same can be said about a List of Numbers:

List<Number> is just a List containing Numbers. List#add accepts a Number, List#get returns a Number…

The difference between a List<Integer> and List<Number> is, that the former may contain just Integers (and sub types) while the later might contain also Doubles, Longs and so on.

Collections: The difference

Following the usual experience, one might think, that that assignment works:

1
2
List<Integer> integerList = new ArrayList<Integer>();
List<Number> numberList = integerList; //!!!! Does not work !!!!!

This assignment shouldn’t be problematic concerning read access. Every read access should return one or more Integers. And since Integer extends Number everything seems to be ok.

1
2
3
List<Integer> integerList = new ArrayList<Integer>();
List<Number> numberList = integerList; //!!!! Does not work !!!!!
Number n = numberList.get(0); //works

But what’s about write access?

The compiler allows you to add any object of type Number to be added to numberList (List<Number>). But of course it must not be possible to add an object of type Number to List<Integer>.

1
2
3
List<Integer> integerList = new ArrayList<Integer>();
List<Number> numberList = integerList; //!!!! Does not work, because of next line!
numberList.add( new Double(2.0 )); //We add a double to List<Integer>!!!!

Fruits…

A list of fruits may contain all kinds of fruits. Apples, strawberries and so on. A list of apples may only contain apples. Therefore a list of apples must never be cast to List<Fruit>.

The solution (at first non intuitional, too)

Some smart minds at Sun discovered that problem. And they also introduced the solution: Wildcards. Just accept wildcards as necessary – because they are.

First the example:

1
2
3
4
List<Integer> integerList = new ArrayList<Integer>();
List<? extends Number> numberList = integerList; //Works!
Number n = numberList.get(0); //works, since every Integer is also a Number
numberList.add( new Double(2.0 )); //Compiler error!!!

We may assign List<Integer> to List<? extends Number> since Integer extends Number.

The declaration List<? extends Number> may be read as: A list of an unknown subtype of Number.

Of course read access is possible. We now that the containing elements must be of type Number. But adding is not possible since the exact type of the list is unknown.

]]> http://blog.cedarsoft.com/2010/01/wildcards-and-collections-part-1/feed/ 0 Why you should only return Collections with bounded wildcards http://blog.cedarsoft.com/2008/01/why-you-should-only-return-collections-with-bounded-wildcards/ http://blog.cedarsoft.com/2008/01/why-you-should-only-return-collections-with-bounded-wildcards/#comments Sat, 12 Jan 2008 22:37:01 +0000 johannes http://blog.cedarsoft.com/?p=20 My post yesterday did not receive much compliance.

Many agreed, that collections with wildcards are usefull as method parameters, most deny their value as type for return values

That’s why I have created a small example that displays the problems not using wildcards. Unfortunately these problems are not very obvious and appear late. Besides that, most of the time the caller has to puzzle with it and maybe you will never hear about it.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
public interface TightList<E> {
  List<E> getIt();
}

final TightList<Integer> integerList = new TightList<Integer>() {
  public List<Integer> getIt() {
    return new ArrayList<Integer>();
  }
};

final TightList<Double> doubleList = new TightList<Double>() {
  public List<Double> getIt() {
    return new ArrayList<Double>();
  }
};


TightList<Number> wrapping = new TightList<Number>() {
  public List<Number> getIt() {
    if ( someFancyCondition ) {
      return doubleList.getIt(); //Compiler error
    } else {
      return integerList.getIt(); //Compiler error
  }
  }
};

I think it is quite obvious what happens here.

We have a simple interface called “TightList” that returns a collection without bounded wildcard. I created three implementations. The first two of them are straight forward – no problems occur here.

But the third one becomes critical. Wrapping the other TightLists is not possible.

Conclusion

There is at least one case, where returning collections without wildcard, is problematic.
Please, oblige the users of your API and add those wildcards (at least when the collection is unmodifiable – and it really should be).

]]> http://blog.cedarsoft.com/2008/01/why-you-should-only-return-collections-with-bounded-wildcards/feed/ 0 Generics and Collections done right (1 foolproof step)… http://blog.cedarsoft.com/2008/01/generics-and-collections-done-right-1-foolproof-step/ http://blog.cedarsoft.com/2008/01/generics-and-collections-done-right-1-foolproof-step/#comments Fri, 11 Jan 2008 22:36:48 +0000 johannes http://blog.cedarsoft.com/?p=19 Generics are surely the biggest change (considered from developers point of view) in Java since a very long time. And they are very powerful and comfortable to use. Learning a new API is *much* easier now.And it also saves a bunch of key presses when using an IDE (who needs Closures when your IDE creates generified anonymous classes?).

But unfortunately very often Generics are used wrongly.

Most of the time most of us are simply too stupid to understand Generics. Do you know anybody that completely understands the concepts? Me neither.

While Generics offer very big improvements for the user in conjunction with Collections, it seems to be hard to set them up correctly (for the design of an API). And there exist several famous failures…

Famous Failures

Google Guice

Although Bob Lee is a brilliant guy (much smarter than I ever will be) there exist several flaws within his great framework Guice.I have created a patch that solves the biggest mistake. Unfortunately the patch has been accepted only partially and just fixed the worst issues.

Glazed List

Uuuh… At least there exists a generified version. But that is the only positive thing that could be said about.Main problem: At the moment it is impossible to register an EventListener to an EventList that has a bounded wildcard (okay you can add some fancy casts to “solve” this issue…).

Assumed you have something like EventList (EventList extendes java.util.List). You won’t be able to register an EvenListener…

So now is the time to improve the world!

Now is the time to improve your API 100 times with just one simple, foolproof step.

You don’t have to fully understand the concepts of Generics (I am far away from it). Just follow this advice and most of the cases will work just as expected:

Never, never, never use any type of Collection *without* (bounded) wildcards in a method signature.

There only exist very few cases where a collection without a wildcard is needed. And most of these cases should be described accurately as hacks.

Don’t return a collection without a (bounded) wildcard.

Wrong:

public List getCustomers();

Instead use:

public List< ? extends Customer> getCustomers();

And please, please never accept a collection without a (bounded) wildcard.

Wrong:

public void addThings( Collection things);

Instead use:

public void addThings( Collection< ? extends Thing> things);

Why is it so important?

It is *very* important because it is not possible to widen a collection later:
List doubleList = new ArrayList();
List numberList = doubleList; //Compiler error!!!

numberList.add(new Integer(4)); //as numberList==doubleList
A list of Doubles is a completely other thing than a list of Numbers. It is often forgotten that Collection classes also offer *write* access. And the compiler must avoid the addition of objects to collections with the wrong type.

The killer argument

You *only* have to know the exact type of a collection, if you try to change that collection (e.g. add an element).

If you return an unmodifiable collection (and you really should in most cases), nobody will ever be able to add an element to that collection. So nobody will ever have to know the *exact* type of that collection.

Return a collection generified with a bounded wildcard and nobody will ever *think* about touching the list!

Same goes for method parameters. In the most cases only the content of the collection is used – no write access is needed! So it isn’t necessary to know the exact type of the collection. Offer the caller a little luxury and go without the additional but completely useless bit of information.

Conclusion:

As long as there is no need for changing a collection use wildcards.

]]> http://blog.cedarsoft.com/2008/01/generics-and-collections-done-right-1-foolproof-step/feed/ 0